Tasharen Entertainment Forum

Support => NGUI 3 Support => Topic started by: r.pedra on August 11, 2016, 12:54:01 PM

Title: UIGrid problem with new SqrMagnitude on low end devices
Post by: r.pedra on August 11, 2016, 12:54:01 PM

Hi Aren,
Second message of the day ahah.

We had some weird problem on our project with the new Vector3.SqrMagnitude you made in UIGrid.ResetPosition.

Here is our setup:

-UIGrid

-Transform
----Widget
----Widget
----Widget
----Widget

When we do our animation, we want each widget to be repositioned. To do so, we use the AddWidget from UIGrid to parent it to the grid.
After that we call UIGrid.Reposition().
Since we have checked animate smoothly, the widget is smoothly going to the Zero point under the grid.
Everything fine.
Then, 0.3 second after the first one have been add to the grid, we resize the grid and we add another widget and call reposition too.

Everything is fine when the framerate is stable.
But when it's not stable, the first widget almost always stays stuck in the center of the grid. Calling Reposition when the framerate is more stable doesn't replace it correctly.
The only way I made it to work is by disabling the Vector3.SqrMagnitude.
In our setup the grid have a width of 175, the widget is stuck in 0,0,0 and the SpringPosition wants to move it to x:-1750 instead of x:-350, but it doesn't move anyway.

This is our code calling doing the animation:

1.         private IEnumerator DrawCardsAsync(){
2.                 for (int i = 0; i < _result.bonusesActivated.Length; i++){
3.                        
4.                         cards[i].Init(_result.bonusesActivated[i],GridToRepositionAfterContentUpdate.transform);
5.                         GridToUpdateWithBonuses.ExecuteUpdateAction();
6.  
7.                         GridToRepositionAfterContentUpdate.Reposition();
8.                         yield return new WaitForSeconds(0.3f);
9.                 }
10.         }

ExcuteUpdateAction is in this script:

1. using UnityEngine;
2.  
3. using System.Collections;
4. using System.Collections.Generic;
5.  
6. [ExecuteInEditMode]
7. public class UIGridFollowsResize : MonoBehaviour
8. {
9.         private UIWidget m_Widget;
10.         private UIPanel m_Panel;
11.         private UIGrid m_uiGrid;
12.         public float numOfColumns = 4.0f;
13.         public float numOfRows = 3.0f;
14.  
15.         private List<Transform> m_childList = new List<Transform>();
16.  
17.         void Start()
18.         {
19.                 m_Widget = GetComponent<UIWidget>();
20.                 m_uiGrid = GetComponent<UIGrid>();
21.         }
22.  
23.         public void updateGrid()
24.         {
25.                 if (m_uiGrid == null) return;
26.  
27.  
28.                 float newHeight;
29.                 float newWidth;
30.                 float newScale;
31.                 if (numOfRows > 0)
32.                 {
33.                         newHeight = m_Widget.height / numOfRows;
34.                 }else{
35.                         newHeight = 0;
36.                 }
37.                 newWidth = m_Widget.width / numOfColumns;
38.  
39.                 m_uiGrid.cellWidth = newWidth ;
40.                 m_uiGrid.cellHeight = newHeight;
41.  
42.                 m_childList = m_uiGrid.GetChildList();
43.                 foreach (Transform child in m_childList)
44.                 {
45.  
46.                         UIWidget childWidget = child.GetComponent<UIWidget>();
47.                         if((newWidth - (AMTools.isHD ? 80f : 40f)) / childWidget.width < (newHeight - (AMTools.isHD ? 60f : 30f)) / childWidget.height){
48.                                 newScale = (newWidth - (AMTools.isHD ? 80f : 40f)) / childWidget.width;
49.                         }else{
50.                                 newScale = (newHeight - (AMTools.isHD ? 60f : 30f)) / childWidget.height;
51.                         }
52.  
53.                         child.localScale = Vector3.one * newScale;
54.                 }
55.         }
56.  
57.         void Update()
58.         {
59.                 if (m_Panel == null) m_Panel = m_Widget.panel;
60.         }
61.  
62.         public void ExecuteUpdateAction(){
63.  
64.                 updateGrid();
65.         }
66.  
67.         public bool update = false;
68.         void OnValidate(){
69.                 if(update == true){
70.                         updateGrid();
71.                         update = false;
72.                 }
73.         }
74. }
75.  

Init is doing this with the transform(and other thing but not related to the transform):

1.         public void Init(APIJSON.SHOP.CARDHOLDER.BonusesActivated bonus, Transform moveParentingTo){
2.                 _bonus = bonus;
3.                 Debug.Log("Bonus:" + JsonUtility.ToJson(_bonus));
4.                 if(firstParent == null){
5.                         firstParent = this.transform.parent;
6.                 }
7.                 moveParentingTo.GetComponent<UIGrid>().AddChild(this.transform);
8.  
9.                 this.gameObject.SetActive(true);
10. }

To simulate the hiccups of the device we made a dirty function:

1.         int nbLags = 0;
2.         private IEnumerator LagsPeriodically()
3.         {
4.                 int i = 0;
5.                 while (i < 1000)
6.                 {
7.                         Debug.Log("LOG");
8.                         i++;
9.                 }
10.  
11.                 nbLags++;
12.                 yield return new WaitForSeconds(0.4f);
13.                 if (nbLags < 5)
14.                 {
15.                         StartCoroutine(LagsPeriodically());
16.                 }else{
17.                         nbLags = 0;
18.                 }
19.         }

Can you take a look at it and tell us if you have the same problem?

Title: Re: UIGrid problem with new SqrMagnitude on low end devices
Post by: ArenMook on August 13, 2016, 04:06:37 PM

I'd need a clean repro case with a project that only has NGUI in it to have a look. You have a lot of custom code there, using custom classes, with a custom setup. I can't re-create your example based on that.