Tasharen Entertainment Forum

Support => NGUI 3 Support => Topic started by: DirtyHippy on January 17, 2014, 02:23:56 PM

Title: UIScrollView bug?
Post by: DirtyHippy on January 17, 2014, 02:23:56 PM
Note: 3.0.8 F6 (posting because I don't see the fix in the F7 release notes).

Shouldn't the line below:

         if (movement == Movement.Horizontal || movement == Movement.Unrestricted)

be:

         if (movement == Movement.Horizontal)

as otherwise if you have movement == Unrestricted and custommovement = {0,1} it will scroll horizontally instead of vertically (because the code then is "new Vector3(mScroll * 0.05f, 0f, 0f));" which scrolls in X even if custom movement is along the Y.


This certainly fixed the problem I was having.

  1.                 // Apply momentum
  2.                 if (mShouldMove && !mPressed)
  3.                 {
  4.                         if (movement == Movement.Horizontal || movement == Movement.Unrestricted)
  5.                         {
  6.                                 mMomentum -= mTrans.TransformDirection(new Vector3(mScroll * 0.05f, 0f, 0f));
  7.                         }
  8.                         else if (movement == Movement.Vertical)
  9.                         {
  10.                                 mMomentum -= mTrans.TransformDirection(new Vector3(0f, mScroll * 0.05f, 0f));
  11.                         }
  12.                         else
  13.                         {
  14.                                 mMomentum -= mTrans.TransformDirection(new Vector3(
  15.                                         mScroll * customMovement.x * 0.05f,
  16.                                         mScroll * customMovement.y * 0.05f, 0f));
  17.                         }
  18.  
Title: Re: UIScrollView bug?
Post by: ArenMook on January 17, 2014, 02:32:20 PM
It should probably be:
  1.                         if (movement == Movement.Horizontal)
  2.                         {
  3.                                 mMomentum -= mTrans.TransformDirection(new Vector3(mScroll * 0.05f, 0f, 0f));
  4.                         }
  5.                         else if (movement == Movement.Vertical)
  6.                         {
  7.                                 mMomentum -= mTrans.TransformDirection(new Vector3(0f, mScroll * 0.05f, 0f));
  8.                         }
  9.                         else if (movement == Movement.Unrestricted)
  10.                         {
  11.                                 mMomentum -= mTrans.TransformDirection(new Vector3(mScroll * 0.05f, mScroll * 0.05f, 0f));
  12.                         }
  13.                         else
  14.                         {
  15.                                 mMomentum -= mTrans.TransformDirection(new Vector3(
  16.                                         mScroll * customMovement.x * 0.05f,
  17.                                         mScroll * customMovement.y * 0.05f, 0f));
  18.                         }