UIDragScrollView resets scrollView

[Markov]

Hi!
after last update, if I set UIDragScrollView.scrollView manually:

1. outlinesObject.scrollView = gameObject.GetComponent<UIScrollView>();

and if there is no UIScrollView in parents, the UIDragScrollView script resets scrollView paremeter to null.
in this line of UIDragScrollView.Press function:

1. if (!pressed && mAutoFind) scrollView = NGUITools.FindInParents<UIScrollView>(mTrans);

can you fix it and add scrollView!= null in this condition?

if (!pressed && mAutoFind && scrollView!= null) scrollView = NGUITools.FindInParents<UIScrollView>(mTrans);

[ArenMook]

Thanks, try the attached script.

[zazery]

Those changes also fixed the problem I encountered yesterday where scrollView wasn't set when adding a child using NGUITools.AddChild.

[ComicSans]

I found another small bug in UIDragScrollView.  NGUI version 3.0.8f7

When UIDragScrollView is first enabled and has no scrollView, mAutoFind is set to true.  If you then manually set scrollView and UIDragScrollView goes through another disable/enable cycle before being pressed, mAutoFind remains set to true at the end of FindScrollView, even though the auto-found view does not match the manual view.

I fixed this in my copy by adding a final else clause to the branches in FindScrollView, setting mAutoFind to false.

Have a good day!

[ArenMook]

Thanks, but if you can remind me about this after the 16th, I'd much appreciate it.

[Isamson]

Bump in case you've forgotten about this

[ArenMook]

I think a more appropriate fix for this would be to only call FindScrollView() if 'mScroll' is null in OnEnable:

1. if (mAutoFind || mScroll == null) FindScrollView();

[renanse]

Sorry for a little necro'ing, but just in case other folks hit this issue, I'm finding that even with your patch above I don't get the desired behavior in at least one case. I have a draggable panel I am adding via code as a sibling GameObject of the GameObject holding my scroll view.  When I add a new draggable area via code (eg, something like this:)

1.                 dragArea = new GameObject("Drag Area");
2.                 dragArea.AddComponent<UIDragScrollView>().scrollView = scrollView;

OnEnable is called as soon as I call AddComponent - before the assignment of scrollView.  Thus, FindScrollView enters the if (scrollView == null) and sets mAutoFind to true.  I worked around that issue by setting the GameObject to inactive before adding the component:

1.                 dragArea = new GameObject("Drag Area");
2.                 dragArea.SetActive(false);
3.                 dragArea.AddComponent<UIDragScrollView>().scrollView = scrollView;
4.                 ...
5.                 dragArea.SetActive(true);

Hope that helps someone.