Messages

1

NGUI 3 Support / Re: Find Bug in UI Widget code

« on: February 14, 2017, 08:42:08 AM »

My Visual Studio apparently decided to make a joke on me. This is what I see in debug mode , and i decided that this is floating point inaccuracy.  But when i deside to look at additional info i found this. . This is not floating point inaccuracy, this is 1 / 255. Sorry I go to kill my UI designer. He made all buttons hover state color (255,254,254,255).

2

NGUI 3 Support / Re: Find Bug in UI Widget code

« on: February 08, 2017, 11:03:37 AM »

Sorry, I certainly meant

1. (mColor != value)

I have buttons without hover state (I just made it's normal and hover colors white), but when I move mouse over button its make button mark as changed. I think that's wrong.
So it seems to me wrong to compare floats that are in different structures.

3

NGUI 3 Support / Find Bug in UI Widget code

« on: February 06, 2017, 10:30:00 AM »

Find little but maybe imortant bug.

public Color color
   {
      get
      {
         return mColor;
      }
      set
      {
         if (mColor.a != value)
                        {
            bool alphaChange = Mathf.Abs(mColor.a - value.a)> Mathf.Epsilon;
            mColor = value;
            Invalidate(alphaChange);
         }
      }
   }

if (mColor.a != value) is always return true if using tween even if it change color from white to white. U cant use "==" to colors which are taken from different behaviours becuse its different structures.

thats my fix

public Color color
   {
      get
      {
         return mColor;
      }
      set
      {
         if (Mathf.Abs(mColor.a - value.a) > 0.005f || Mathf.Abs(mColor.r - value.r) > 0.005f || Mathf.Abs(mColor.b - value.b) > 0.005f || Mathf.Abs(mColor.g - value.g) > 0.005f)
            {
            bool alphaChange = Mathf.Abs(mColor.a - value.a)> Mathf.Epsilon;
            mColor = value;
            Invalidate(alphaChange);
         }
      }
   }