Code Change Requests

[Ferazel]

Since it appears that there is an impeding release of another new version of NGUI could I request some additional features to the NGUI so I don't have to keep changing it whenever I upgrade?

UISliderInspector
Could I request to change the following in the UISliderInspector file so that the slider steps is an int field instead of a slider? 

Replace this:

1. void OnInspectorGUI() {
2. ...
3.     int steps = EditorGUILayout.Slider("Steps", slider.numberOfSteps, 0, 11);
4. ...
5. }
6.  

With this?

1. void OnInspectorGUI() {
2. ...
3.     int steps = EditorGUILayout.IntField("Steps", slider.numberOfSteps);
4.     if(steps < 0) {
5.         steps = 0;
6.     }
7. ...
8. }
9.  

UIInput
The other request is to change it so that the UIInput has a boolean toggle for allowing auto-correct on handheld devices.

1. [AddComponentMenu("NGUI/UI/Input (Basic)")]
2. public class UIInput : MonoBehaviour
3. {
4. ...
5.         /// <summary>
6.         /// The use auto correct function when on iOS/Android platforms
7.         /// </summary>
8.         public bool useAutoCorrect = false;
9. ...
10.  
11.     public void OnSelect(bool isSelected) {
12. ...
13. #if UNITY_IPHONE || UNITY_ANDROID
14.        if (Application.platform == RuntimePlatform.IPhonePlayer || Application.platform == RuntimePlatform.Android)
15.        {
16. #if UNITY_3_4
17.               mKeyboard = iPhoneKeyboard.Open(mText, (iPhoneKeyboardType)((int)type), useAutoCorrect);
18. #else
19.               if (isPassword)
20.               {
21.                  mKeyboard = TouchScreenKeyboard.Open(mText, TouchScreenKeyboardType.Default, false, false, true);
22.               }
23.               else
24.               {
25.                  mKeyboard = TouchScreenKeyboard.Open(mText, (TouchScreenKeyboardType)((int)type), useAutoCorrect);
26.               }
27. #endif
28. ...
29.     }
30. }
31.  

That would be appreciated! Let me know if there is anything else you need.

Thanks!

[ArenMook]

2.2.7 went out 2 days ago, so you kind of missed the "impending release"

[Ferazel]

2.2.7 went out 2 days ago, so you kind of missed the "impending release"

Oh I thought the post that you posted here (http://www.tasharen.com/forum/index.php?topic=2702.0) today stated that there was a bug that would be fixed in an upcoming release. So I just thought I'd try to sneak these changes in as well in the next update.

[cayou]

+1 for the UISlider, a customizable value of steps will be great (I had to change hardly on code to add extra steps).

[Ferazel]

Sadness bump that these changes weren't included in 2.3.0

[cayou]

Yes...
And the support of movieTexture into clipped panels.... 

[ArenMook]

I don't like the steps change. 10 steps is already a lot. If you need more, create your own custom slider or don't use steps at all.

The auto-correct change... I'll add that in.

[Ferazel]

Well it's your UI solution (obviously), but my argument would be that imposing an artificial limit about how a slider will be used (when there is no apprent side effect) is a mistake. The slider where I wanted more than 10 steps is one that would encompass the entire height of the screen, therefore would have more than enough space to have distinct steps of a value. Regardless, it's not a huge change in the rare cases that the code, but just an annoyance every time we update.

Glad to see the auto-correct in there though. Naturally, it might only be visible in #if UNITY_IPHONE || UNITY_ANDROID, but I thought I read somewhere that conditionally compiled serialized script variables could lead to bad behavior so I didn't include that.

Thank you for your continued improvement and support of NGUI.

[ArenMook]

You can always use math on the retrieved sliderValue, resulting in steps. For example:

1. float stepValue = Mathf.Round(myslider.sliderValue * 20f) / 20f;