Sprites in prefab reverting

[boofcpw]

Hey,

Recently I have been experiencing an issue with buttons in a prefab.

Whenever I change the sprite that they use, upon applying the prefab, the sprite reverts back to what was originally in the prefab.
I haven't experienced this before, so I'm not sure if I'm doing something silly or there is an issue with the new version, but any help would be great!

[boofcpw]

So I have figured that this only happens to buttons with box colliders. If I remove the box collider then apply the prefab, the sprite does not revert. However, when I add a new box collider then apply, the sprite once again reverts. Im pretty stumped.

[ArenMook]

In what version of NGUI? This was addressed back in 3.5.8

[boofcpw]

Version 3.5.9

[ArenMook]

Alright, then I'm not sure what would be the case. The normal sprite is not saved in any way. It's marked as "NonSerialized" in UIButton.cs. Changing the normal sprite actually changes the current sprite's spriteName directly (UIButtonEditor.cs line 52). I don't see anything wrong on my end. Changing the sprite and hitting Apply does not revert in my case, with or without a collider. Is there a step-by-step repro case you can provide?

[boofcpw]

I created a completely new project and reproduced the issue. Here are the steps required:

new project
import ngui 3.5.9
import two texture
create atlas from two texture (initially created an error. different issue, but probably something to look at)
Add 2d ui to scene
save scene
create panel
create sprite (under panel)
set sprite to use atlas and sprite
add UI button script to sprite
add collider to sprite
save scene
run scene (button works)
Create a prefab
drag panel into prefab
copy sprite (with button on it)
change new buttons sprite
select panel
press apply
second button reverts back to original buttons sprite

Hope that helps

[boofcpw]

Just another note. Both sprites revert when changed. not just the copied one.

[ArenMook]

Reproduced, thanks. I will look into this.

[boofcpw]

Thanks a lot

[ArenMook]

Fixed in 3.6.0 btw.

[boofcpw]

Awesome!

[boofcpw]

Hey, just updated (3.6.0) and am still occasionally getting this issue.

Does the change you did fix buttons which had the issue previously, or does it only fix newly created ones?

[ArenMook]

It should fix everything. How often are you still seeing the issue, and is there any way to reproduce it consistently?

[boofcpw]

Every time I copy a button and change the sprite, it reverts upon pressing apply. This is with an existing project. I have not had a chance today to start a fresh project and get the exact steps required to reproduce the issue, but I cant imagine it would be too different.

Just to clarify, what I am currently doing is:

Copy button (consists of sprite, button, collider, button scale)
Change new buttons sprite
Apply prefab
New button reverts to old buttons sprite.

To be clear, I definitely did upgrade NGUI properly (nuke it from orbit), and am definitely running the latest version.

Ill try get a reproducible from a fresh project when I get the chance. Its a busy week 

[boofcpw]

I just opened up the project I made to reproduce the issue last time, and upgraded NGUI to make sure that it fixed that issue, but that project is still having the same problem.

I created a new project, and began repeating the steps of the original bug, and found several things

1) not related, but still something that does happen pretty often. When creating an atlas, getting the error "MissingReferenceException: The object of type 'Texture2D' has been destroyed but you are still trying to access it."

2) when I first created a sprite, the sprite name was by default set as a sprite that is in a completely different project (might not be a problem/related, but I found that interesting)

3) the same bug with the applying prefab/reverting sprite.

If you follow the steps I posted previously, you should still be getting the same problem.

Thanks!